Break a part CLI and CLI tests into their respective packages #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
redhatrises
commented
Jun 7, 2018
redhatrises
commented
- Replace codegangsta/cli with the more advanced cobra cli
- diff.go shoudn't be in main
- Fix diff tests
- Move pkg cli tests to their respective packages
- Update vendor dependencies
- Replace codegangsta/cli with the more advanced cobra cli - diff.go shoudn't be in main - Fix diff tests - Move pkg cli tests to their respective packages - Update vendor dependencies
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
==========================================
- Coverage 89.48% 86.75% -2.73%
==========================================
Files 32 32
Lines 1027 1012 -15
==========================================
- Hits 919 878 -41
- Misses 88 116 +28
+ Partials 20 18 -2
Continue to review full report at Codecov.
|
redhatrises
force-pushed
the
cli_fixes
branch
2 times, most recently
from
636f28b to
ce31a59
Compare
|
codeclimate errors are legacy things that will occasionally popup during refactoring -- reviewed, but ignoring for this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.